SuccessChanges

Summary

  1. Improve Cancelled Block Place Tile Entity discardment (commit: 0ff0c18) (details)
  2. Optimize Captured TileEntity Lookup (commit: c36f206) (details)
Commit 0ff0c182380dbf469f3606adc25ebbe7804016c7 by aikar
Improve Cancelled Block Place Tile Entity discardment
We bandaided this logic on a case by case basis before with Loot Tables
and Chests, but that is not the correct fix.
Ultimately we just needed to clear out the captured tile entity list so
that the update calls did not process the tile entity that is no longer
even valid.
This solution will ensure ALL placed tile entities data is ignored and
not just the few cases we previously had filters for.
(commit: 0ff0c18)
The file was modifiedSpigot-Server-Patches/0347-Allow-chests-to-be-placed-with-NBT-data.patch (diff)
The file was removedSpigot-Server-Patches/0436-Clear-containers-when-block-place-is-cancelled.patch
Commit c36f2062091622baf6307e35e60e389f47abf451 by aikar
Optimize Captured TileEntity Lookup
upstream was doing a containsKey/get pattern, and always doing it at
that. that scenario is only even valid if were in the middle of a block
place.
Optimize to check if the captured list even has values in it, and also
to just do a get call since the value can never be null.
(commit: c36f206)
The file was addedSpigot-Server-Patches/0436-Optimize-Captured-TileEntity-Lookup.patch